Re: [Patch, microblaze]: Add TARGET_ASM_OUTPUT_MI_THUNK to support varargs thunk

[Michael Eager <eager at eagerm dot com>]

On 02/14/14 09:41, Michael Eager wrote:
> On 02/13/14 21:48, David Holsgrove wrote:
> > Hi Michael,
> >
> > > -----Original Message-----
> > > From: Michael Eager [mailto:eager@eagerm.com]
> > > Sent: Sunday, 26 January 2014 1:57 am
> > > To: David Holsgrove
> > > Cc: gcc-patches@gcc.gnu.org; Edgar Iglesias; John Williams; Vinod Kathail;
> > > Vidhumouli Hunsigida; Nagaraju Mekala; Tom Shui
> > > Subject: Re: [Patch, microblaze]: Add TARGET_ASM_OUTPUT_MI_THUNK to
> > > support varargs thunk
> > >
> > > On 07/14/13 21:37, David Holsgrove wrote:
> > > > Hi Michael,
> > > >
> > > > > -----Original Message-----
> > > > > From: Michael Eager [mailto:eager@eagerm.com]
> > > > > Sent: Saturday, 13 July 2013 9:33 am
> > > > > To: David Holsgrove
> > > > > Cc: gcc-patches@gcc.gnu.org; Edgar Iglesias; John Williams; Vinod Kathail;
> > > > > Vidhumouli Hunsigida; Nagaraju Mekala; Tom Shui
> > > > > Subject: Re: [Patch, microblaze]: Add TARGET_ASM_OUTPUT_MI_THUNK to
> > > > > support varargs thunk
> > > > >
> > > > > On 03/18/13 05:49, David Holsgrove wrote:
> > > > > > Changelog
> > > > > >
> > > > > > 2013-03-18  David Holsgrove <david.holsgrove@xilinx.com>
> > > > > >
> > > > > >     * gcc/config/microblaze/microblaze.c: Add
> > > microblaze_asm_output_mi_thunk
> > > > > >       and define TARGET_ASM_OUTPUT_MI_THUNK and
> > > > > TARGET_ASM_CAN_OUTPUT_MI_THUNK
> > > > >
> > > > > Sorry it has taken so long to review this patch.
> > [--snip--]
> > > > 2013-07-15  David Holsgrove <david.holsgrove@xilinx.com>
> > > >
> > > >    * gcc/config/microblaze/microblaze.c: Add microblaze_asm_output_mi_thunk
> > > >      and define TARGET_ASM_OUTPUT_MI_THUNK and
> > > TARGET_ASM_CAN_OUTPUT_MI_THUNK
> > >
> > > This patch causes a number of regressions in the G++ test suite.
> > > For example, abi/covariant{3,4,5}.C, abi/vcall1.C,
> > > inherit/covariant{1,2,3,4,17,18}.C,
> > > inherit/thunk{7,10}.C and others.
> >
> > Apologies - this patch was originally written in 2012 and submitted to this list a year ago.
> > It has not been reviewed or tested for regressions in 12 months, and has taken me a bit of time to
> > go back to the original work and rerun the testsuite as it stands today.
> >
> > Please find attached updated patch which has no regressions. I believe the testcase which checks
> > the functionality of this patch is ' g++.old-deja/g++.jason/thunk3.C'
> >
> > Changelog entry remains the same since March 2013.
>
> Thanks.

gcc-head: Committed revision 208057.
gcc-4_8_branch: Committed revision 208058.

--
Michael Eager	 eager@eagercon.com
1960 Park Blvd., Palo Alto, CA 94306  650-325-8077