This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C PATCH] Kill bogus warnings on _Atomics (PR c/60195)
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 18 Feb 2014 23:44:08 +0000
- Subject: Re: [C PATCH] Kill bogus warnings on _Atomics (PR c/60195)
- Authentication-results: sourceware.org; auth=none
- References: <20140218190853 dot GJ8907 at redhat dot com>
On Tue, 18 Feb 2014, Marek Polacek wrote:
> This PR is about bogus warnings on _Atomics. E.g., for _Atomic int,
> the warning "right-hand operand of comma has no effect" makes no sense. One
> problem was that when making COMPOUND_EXPR out of atomic variable, we create
> artificial variable via create_tmp_var, but we shouldn't warn on those. So
> I've set TREE_NO_WARNING on such variables.
> Another issue is that we warned that a variable is unused, even when it's
> actually used in __atomic_load; mark_exp_read fixed it.
>
> Also I noticed a typo, so fixed (s/val/old/).
>
> Regtested/bootstrapped on x86_64-linux, ok for 5.0? (Or 4.9 instead?)
OK for 4.9.
--
Joseph S. Myers
joseph@codesourcery.com