This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, rs6000] Fix powerpc64le-linux bootstrap failure with -mcpu=power8
- From: David Edelsohn <dje dot gcc at gmail dot com>
- To: Bill Schmidt <wschmidt at linux dot vnet dot ibm dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 16 Feb 2014 17:04:15 -0500
- Subject: Re: [PATCH, rs6000] Fix powerpc64le-linux bootstrap failure with -mcpu=power8
- Authentication-results: sourceware.org; auth=none
- References: <1392567538 dot 20991 dot 17 dot camel at gnopaine>
On Sun, Feb 16, 2014 at 11:18 AM, Bill Schmidt
<wschmidt@linux.vnet.ibm.com> wrote:
> Hi,
>
> Now that I have Power8 hardware to test on, I've discovered that I
> introduced a problem with
> http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01547.html that causes a
> bootstrap failure when specifying -mcpu=power8. I moved some logic from
> rs6000_expand_vec_perm_const_1 into vsx_xxpermdi2_<mode>_1. I failed to
> notice there is another path into vsx_xxpermdi2_<mode>_1 that is
> exercised during the bootstrap.
>
> To avoid the problem, this patch adjusts the code generated along this
> other path so that the later transformation will be correct.
>
> Bootstrapped and tested on powerpc64{,le}-unknown-linux-gnu configured
> both with -mcpu=power7 and with -mcpu=power8 with no regressions. The
> Power8 LE bootstrap now completes cleanly. Is this ok for trunk?
>
> Thanks,
> Bill
>
>
> 2014-02-16 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
>
> * config/rs6000/vsx.md (vsx_xxpermdi_<mode>): Handle little
> endian targets.
I'm not really thrilled with the need to reverse the operands twice, but okay.
Thanks, David