This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][RFC][libatomic] Override -mcpu option for arm linux ifunc targets
- From: Richard Henderson <rth at redhat dot com>
- To: Kyrill Tkachov <kyrylo dot tkachov at arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 13 Feb 2014 10:23:50 -0800
- Subject: Re: [PATCH][RFC][libatomic] Override -mcpu option for arm linux ifunc targets
- Authentication-results: sourceware.org; auth=none
- References: <52EF829A dot 9010808 at arm dot com>
On 02/03/2014 03:50 AM, Kyrill Tkachov wrote:
> +# For ARM, the -march option by itself conflicts with any -mcpu option that
> +# we might end up passing to the build, causing an error.
> +# Therefore we override the -mcpu option as well.
> +# This shouldn't affect tuning much because the affected code is mostly
> +# in inline assembly anyway.
> @ARCH_ARM_LINUX_TRUE@@HAVE_IFUNC_TRUE@IFUNC_OPTIONS = -march=armv7-a -DHAVE_KERNEL64
> +@ARCH_ARM_LINUX_TRUE@@HAVE_IFUNC_TRUE@EXTRA_OVERRIDE = -mcpu=cortex-a9
Why would you want to split these across two different variables? It's easier
to just add the -march and -mcpu to the same IFUNC_OPTIONS variable.
Why the choice of cortext-a9, as opposed to any of the other v7-a
possibilities? If we're going to force anything, perhaps generic-armv7-a is
more appropriate?
r~