Re: [PATCH 4/6] [GOMP4] OpenACC 1.0+ support in fortran front-end

[Thomas Schwinge <thomas at codesourcery dot com>]

Hi Ilmir!

On Thu, 13 Feb 2014 17:15:47 +0400, Ilmir Usmanov <i.usmanov@samsung.com> wrote:
> I fixed patch according to your review and ready to commit it. OK for 
> GOMP4 branch?

Yes!  :-) Congratulations, and thanks for promptly addressing the issues
raised during review.  I'm aware this can be a bit of a boring or tedious
process, but in the end, the code quality will be higher (well, that's
the idea about code review), and certainly you'll have learned some
things, too (and I have, too), and so next time this process will likely
be faster.


Only a few minor comments about the ChangeLog formatting:

> 13-02-2014  Ilmir Usmanov  <i.usmanov@samsung.com>

YYYY-MM-DD is the format used in ChangeLogs.

> 	Add OpenACC 1.0 support to GENERIC, except loop directive and subarrays.
> 
> 	Dmitry Bocharnikov <dmitry.b@samsung.com>
> 	Evgeny Gavrin <e.gavrin@samsung.com>
> 	Ilmir Usmanov <i.usmanov@samsung.com>

For multiple authors, do it like this:

2014-02-13  Ilmir Usmanov  <i.usmanov@samsung.com>
	    Dmitry Bocharnikov  <dmitry.b@samsung.com>
	    Evgeny Gavrin  <e.gavrin@samsung.com>

|> 	gcc/
|> 	* gimplify.c (is_gimple_stmt): Stub OpenACC directives and clauses.
|> 	(gimplify_scan_omp_clauses, gimplify_adjust_omp_clauses): Likewise.
|> 	(gimplify_expr): Likewise.

(I don't care, but) you can also do it as follows, a bit simpler:

	* [file] ([item 1], [item 2], [...]): [text].

|> 	* tree-core.h 
|> 	(OMP_CLAUSE_HOST, OMP_CLAUSE_OACC_DEVICE, OMP_CLAUSE_DEVICE_RESIDENT,
|> 	OMP_CLAUSE_USE_DEVICE, OMP_CLAUSE_GANG, OMP_CLAUSE_WAIT,
|> 	OMP_NO_CLAUSE_CACHE, OMP_CLAUSE_INDEPENDENT, OMP_CLAUSE_ASYNC,
|> 	OMP_CLAUSE_WORKER, OMP_CLAUSE_VECTOR, OMP_CLAUSE_NUM_GANGS,
|> 	OMP_CLAUSE_NUM_WORKERS, OMP_CLAUSE_VECTOR_LENGTH): New clauses.

As the enum omp_clause_code is the thing that you modify, that would be:

	* tree-core.h (enum omp_clause_code): Add OMP_CLAUSE_HOST, [...].

Or, as other people do:

	* tree-core.h (omp_clause_code): Add OMP_CLAUSE_HOST, [...].


GrÃÃe,
 Thomas

Attachment: pgpVjYIr3y1_g.pgp
Description: PGP signature