This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix ubsan expansion of multiplication (PR rtl-optimization/60030)
- From: Richard Henderson <rth at redhat dot com>
- To: Jakub Jelinek <jakub at redhat dot com>, Richard Biener <rguenther at suse dot de>, Jeff Law <law at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 06 Feb 2014 06:53:55 -0800
- Subject: Re: [PATCH] Fix ubsan expansion of multiplication (PR rtl-optimization/60030)
- Authentication-results: sourceware.org; auth=none
- References: <20140204124045 dot GJ12671 at tucnak dot redhat dot com>
On 02/04/2014 04:40 AM, Jakub Jelinek wrote:
> - tem = expand_shift (LSHIFT_EXPR, mode, lopart, hprec, NULL_RTX, 1);
> + tem = gen_rtx_SUBREG (mode, lopart, 0);
> + tem = expand_shift (LSHIFT_EXPR, mode, tem, hprec, NULL_RTX, 1);
I would be happier with gen_lowpart rather than the explicit gen_rtx_subreg.
Ok with that change.
r~