This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix ix86_function_regparm with optimize attribute (PR target/60062, take 3)
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Richard Biener <rguenther at suse dot de>
- Cc: Jakub Jelinek <jakub at redhat dot com>, Jan Hubicka <hubicka at ucw dot cz>, Richard Henderson <rth at redhat dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 6 Feb 2014 11:15:24 +0100
- Subject: Re: [PATCH] Fix ix86_function_regparm with optimize attribute (PR target/60062, take 3)
- Authentication-results: sourceware.org; auth=none
- References: <20140205123722 dot GB12671 at tucnak dot redhat dot com> <alpine dot LSU dot 2 dot 11 dot 1402051418260 dot 29326 at zhemvz dot fhfr dot qr> <20140205194227 dot GG12671 at tucnak dot redhat dot com> <20140206070928 dot GM12671 at tucnak dot redhat dot com> <alpine dot LSU dot 2 dot 11 dot 1402061045150 dot 29326 at zhemvz dot fhfr dot qr>
On Thu, Feb 6, 2014 at 10:45 AM, Richard Biener <rguenther@suse.de> wrote:
> On Thu, 6 Feb 2014, Jakub Jelinek wrote:
>
>> On Wed, Feb 05, 2014 at 08:42:27PM +0100, Jakub Jelinek wrote:
>> > So, where do we want to do that instead? E.g. should it be e.g. in
>> > tree_versionable_function_p directly and let the inliner (if it doesn't do
>> > already) also treat optimize(0) functions that aren't always_inline as
>> > noinline?
>>
>> So, another attempt to put the && opt_for_fn (fndecl, optimize) into
>> tree_versionable_function_p also failed, because e.g. for TM (but also for
>> SIMD clones) we need to clone -O0 functions. So, can I fix PR600{6,7}2
>> without touching tree-inline.c and fix PR60026 again separately somehow else
>> as follow-up? Bootstrapped/regtested on x86_64-linux and i686-linux.
>
> That works for me.
Also OK for x86.
Thanks,
Uros.