RE: regression test issue

["Iyer, Balaji V" <balaji dot v dot iyer at intel dot com>]

> -----Original Message-----
> From: Paolo Carlini [mailto:paolo.carlini@oracle.com]
> Sent: Wednesday, February 5, 2014 11:53 AM
> To: Iyer, Balaji V; gcc-patches@gcc.gnu.org
> Subject: Re: regression test issue
> 
> Hi,
> 
> On 02/05/2014 06:29 AM, Iyer, Balaji V wrote:
> > Hello Everyone,
> > 	The following two Cilk Plus tests is timing out at -O1 in my x86_64 box
> (-O2, -O3  and -O0 works fine). These tests were working fine till revision
> r207047. Can someone please look at this? It looks like a middle-end/back-
> end issue.
> >
> > WARNING: program timed out.
> > FAIL: g++.dg/cilk-plus/CK/catch_exc.cc  -O1 -fcilkplus execution test
> > WARNING: program timed out.
> > FAIL: c-c++-common/cilk-plus/CK/spawner_inline.c  -O1 execution test
> Thanks. I'm wondering if we could open an high priority Bugzilla about that
> and for the time being avoid running the test at -O1, it is slowing down the
> testsuite and using a lot of cpu. Also, maybe you could figure out which
> specific change caused the regression and ping the appropriate people...

Hi Paolo,	
	OK. Here is a patch that will do so:

Index: gcc/testsuite/g++.dg/cilk-plus/cilk-plus.exp
===================================================================
--- gcc/testsuite/g++.dg/cilk-plus/cilk-plus.exp        (revision 207437)
+++ gcc/testsuite/g++.dg/cilk-plus/cilk-plus.exp        (working copy)
@@ -64,12 +64,12 @@
 dg-runtest [lsort [glob -nocomplain $srcdir/g++.dg/cilk-plus/AN/*.cc]] " -O3 -ftree-vectorize -fcilkplus -g" " "

 if { [check_libcilkrts_available] } {
-    dg-runtest [lsort [glob -nocomplain $srcdir/g++.dg/cilk-plus/CK/*.cc]] " -O1 -fcilkplus" " "
+#    dg-runtest [lsort [glob -nocomplain $srcdir/g++.dg/cilk-plus/CK/*.cc]] " -O1 -fcilkplus" " "
     dg-runtest [lsort [glob -nocomplain $srcdir/g++.dg/cilk-plus/CK/*.cc]] " -O3 -fcilkplus" " "
     dg-runtest [lsort [glob -nocomplain $srcdir/g++.dg/cilk-plus/CK/*.cc]] " -g -fcilkplus" " "
     dg-runtest [lsort [glob -nocomplain $srcdir/g++.dg/cilk-plus/CK/*.cc]] " -g -O2 -fcilkplus" " "

-    dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/CK/*.c]] " -O1" " "
+#    dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/CK/*.c]] " -O1" " "
     dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/CK/*.c]] " -O3" " "
     dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/CK/*.c]] " -g" " "
     dg-runtest [lsort [glob -nocomplain $srcdir/c-c++-common/cilk-plus/CK/*.c]] " -g -O2" " "
===========================================================================

Here is the ChangeLog entry:

2014-02-05  Balaji V. Iyer  <balaji.v.iyer@intel.com>

        * g++.dg/cilk-plus/cilk-plus.exp: Commented out -O1 Cilk Keywords
        test for the time-being.


Note: I am purposely commenting the line out and not deleting them because I want to get them to run in -O1 some time, and deleting them might cause us (atleast me :-). ) to forget about it.

I will go ahead and file a bugzilla report.

Thanks,

Balaji V. Iyer.


> 
> Thanks again,
> Paolo.