This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch AArch64] Implement Vector Permute Support
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Alex Velenko <Alex dot Velenko at arm dot com>
- Cc: "pinskia at gmail dot com" <pinskia at gmail dot com>, James Greenhalgh <James dot Greenhalgh at arm dot com>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Tejas Belagod <Tejas dot Belagod at arm dot com>
- Date: Mon, 20 Jan 2014 11:16:54 +0000
- Subject: Re: [Patch AArch64] Implement Vector Permute Support
- Authentication-results: sourceware.org; auth=none
- References: <1354617087-31993-1-git-send-email-james dot greenhalgh at arm dot com> <CA+=Sn1=Zhqkts++ZXobYWQYK2g5K1r-8CU=Eu57X1fgcfG-1=A at mail dot gmail dot com> <72A61951-68B2-4776-A2B8-05DC4E1F53A7 at arm dot com> <CA+=Sn1mtu9kwaFrrtjjVnsgbxhh2hHxGkHE+zr8OnR75b75VgA at mail dot gmail dot com> <20140108105959 dot GA26808 at arm dot com> <52D5558E dot 7040609 at arm dot com> <15698059-D4C6-4499-A3B2-6C88BDDAFC5E at gmail dot com> <52D7F00D dot 1030206 at arm dot com> <52D95278 dot 9080408 at arm dot com> <52DD0563 dot 6030804 at arm dot com>
On 20/01/14 11:15, Alex Velenko wrote:
> On 17/01/14 15:55, Richard Earnshaw wrote:
>> On 16/01/14 14:43, Alex Velenko wrote:
>>> On 14/01/14 15:51, pinskia@gmail.com wrote:
>>>>
>>>>
>>>>> On Jan 14, 2014, at 7:19 AM, Alex Velenko <Alex.Velenko@arm.com> wrote:
>>>>>
>>>>> Hi,
>>>>>
>>>>> This patch turns off the vec_perm patterns for aarch64_be, this should resolve
>>>>> the issue highlighted here http://gcc.gnu.org/ml/gcc-patches/2014-01/msg00321.html
>>>>> With this patch applied, the test case provided in that link compiles without an ICE.
>>>>>
>>>>> However, the Big-Endian port is still in development. This patch exposes
>>>>> another known but unrelated issue with Big-Endian Large-Int modes.
>>>>>
>>>>> The patch has been tested on aarch64-none-elf and aarch64_be-none-elf resulting in five
>>>>> further regression due to the broken implementation of Big-Endian Large-Int modes.
>>>>>
>>>>> Kind regards,
>>>>> Alex Velenko
>>>>>
>>>>> gcc/
>>>>>
>>>>> 2014-01-14 Alex Velenko <Alex.Velenko@arm.com>
>>>>>
>>>>> * config/aarch64/aarch64-simd.md (vec_perm<mode>): Add BE check.
>>>>> * config/aarch64/aarch64.c (aarch64_expand_vec_perm): Add comment.
>>>>>
>>>>> gcc/testsuite/
>>>>>
>>>>> 2014-01-14 Alex Velenko <Alex.Velenko@arm.com>
>>>>>
>>>>> * lib/target-supports.exp
>>>>> (check_effective_target_vect_perm): Exclude aarch64_be.
>>>>> (check_effective_target_vect_perm_byte): Likewise.
>>>>> (check_effective_target_vect_perm_short): Likewise.
>>>>
>>>> I think you want to use a function to check if the target is effectively big-endian instead. Internally at Cavium, our elf compiler has big-endian multi-lib.
>>>>
>>>> Thanks,
>>>> Andrew
>>>>
>>>>>
>>>>> <vec-perm.patch>
>>>>
>>>
>>> Hi,
>>> Here is a vec-perm patch with changes proposed previously.
>>> Little and Big-Endian tested with no additional issues appearing.
>>>
>>> Kind regards,
>>> Alex
>>>
>>> gcc/
>>>
>>> 2014-01-16 Alex Velenko <Alex.Velenko@arm.com>
>>>
>>> * config/aarch64/aarch64-simd.md (vec_perm<mode>): Add BE check.
>>> * config/aarch64/aarch64.c (aarch64_expand_vec_perm): Add comment.
>>>
>>> gcc/testsuite/
>>>
>>> 2014-01-16 Alex Velenko <Alex.Velenko@arm.com>
>>>
>>> * lib/target-supports.exp
>>> (check_effective_target_vect_perm): Exclude aarch64_be.
>>> (check_effective_target_vect_perm_byte): Likewise.
>>> (check_effective_target_vect_perm_short): Likewise.
>>>
>>
>> The patch is missing the hunk for aarch64.c.
>>
>>
>
> Hi,
> It is a faulty changelog entry, not patch.
> Should be:
>
> gcc/
>
> 2014-01-16 Alex Velenko <Alex.Velenko@arm.com>
>
> * config/aarch64/aarch64-simd.md (vec_perm<mode>): Add BE check.
>
> gcc/testsuite/
>
> 2014-01-16 Alex Velenko <Alex.Velenko@arm.com>
>
> * lib/target-supports.exp
> (check_effective_target_vect_perm): Exclude aarch64_be.
> (check_effective_target_vect_perm_byte): Likewise.
> (check_effective_target_vect_perm_short): Likewise.
>
On that basis, OK.
R.