This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] Regex bracket matcher cache optimization
- From: Jonathan Wakely <jwakely dot gcc at gmail dot com>
- To: Tim Shen <timshen91 at gmail dot com>
- Cc: Paolo Carlini <paolo dot carlini at oracle dot com>, "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 17 Jan 2014 09:39:00 +0000
- Subject: Re: [Patch] Regex bracket matcher cache optimization
- Authentication-results: sourceware.org; auth=none
- References: <CAPrifDnXTpH6K2A6O41OOx34AVMKKm=-gXPh7J0Sjq9=9rM8+g at mail dot gmail dot com> <CAPrifDkC0iSROtATApvp4_h9Je1S7XcahUBnOzK9g4ZdgYsBEg at mail dot gmail dot com> <52CBC2C1 dot 6060908 at oracle dot com> <CAPrifDkATveVCsq0RFn-6VadkOgEjOiKV-LYWGgy5tZg0MxSyA at mail dot gmail dot com> <CAH6eHdSkRPbeLE_ZG41LvtxA=7CpPzq=i3OeCb-JJHrp-Xqkvw at mail dot gmail dot com> <52CD2683 dot 1040104 at oracle dot com> <CAPrifD=9vYKtXBt1wta=FSnTqNqj9h=U5hKfPt5+wMx-U5Qp+w at mail dot gmail dot com> <52CDD37B dot 7050809 at oracle dot com> <CAPrifDmPa+8NOotknp7k8bcR4nXzgV_6ZuxqtZb3qzZ-PPpOow at mail dot gmail dot com>
On 8 January 2014 22:47, Tim Shen wrote:
>
> So my plan is to instantiate _Compiler and _Executor instead of user
> interfaces like basic_regex or regex_match, because the implementation
> may change (say add a new executor) later. Is that Ok?
I think we want to be cautious with exporting instantiations (and as
Paolo noted we definitely don't want to do it for 4.9.0 now). Slow
compile times are a problem, but only a minor annoyance. Exporting
symbols that might change is a bigger problem, as we have to keep
exporting them once they're in the library. The current
implementation is new for 4.9, so I think we can live with it being
slow to compile for its first release. After 4.9.0 we will have more
user feedback and more experience with it, and for the next major
release will know what's stable enough to export "forever" from the
library.