This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch] Patch set for regex instantiation


On Sun, Jan 12, 2014 at 5:32 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> Thanks, but as we already tried to explain, instantiating, thus adding many exported symbols, is post 4.9 material, can't be committed until we branch. Please make sure to have in a separate patch or multiple patches the correctness fixes and maybe anything unrelated to instantiation which you consider stable and independently useful.

Sorry, didn't notice that :(. Luckily a slight change removes all abi
modification part.

1) Create class _ScannerBase to make _Scanner pithier.
2) Make _Compiler and _Scanner `_FwdIter independent`. We store the
input regex string in basic_regex as a basic_string; but when
compiling it, const _CharT* is used.
3) Avoid using std::map, std::set and std::queue to reduce compile time.

Booted and tested with -m64 and -m32 respectively, and check-debug; by
the way, along with previous patch in the mail "[Patch] Regex bracket
matcher cache optimization".

Thanks!


-- 
Regards,
Tim Shen

Attachment: 1.diff
Description: Text document

Attachment: 2.diff
Description: Text document

Attachment: 3.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]