This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Question about gimplify.c:gimplify_adjust_omp_clauses_1, GOVD_MAP_TO_ONLY

From: Thomas Schwinge <thomas_schwinge at mentor dot com>
To: Jakub Jelinek <jakub at redhat dot com>, <gcc-patches at gcc dot gnu dot org>
Date: Thu, 9 Jan 2014 21:38:25 +0100
Subject: Question about gimplify.c:gimplify_adjust_omp_clauses_1, GOVD_MAP_TO_ONLY
Authentication-results: sourceware.org; auth=none

Hi!

In gimplify.c:gimplify_adjust_omp_clauses_1, does the case for
GOVD_MAP_TO_ONLY have a real current use case (I couldn't spot any), or
is it "just for completeness"?

diff --git gcc/gimplify.c gcc/gimplify.c
index 3738589..870550c 100644
--- gcc/gimplify.c
+++ gcc/gimplify.c
@@ -6136,9 +6136,9 @@ gimplify_adjust_omp_clauses_1 (splay_tree_node n, void *data)
     OMP_CLAUSE_PRIVATE_OUTER_REF (clause) = 1;
   else if (code == OMP_CLAUSE_MAP)
     {
-      OMP_CLAUSE_MAP_KIND (clause) = flags & GOVD_MAP_TO_ONLY
-				     ? OMP_CLAUSE_MAP_TO
-				     : OMP_CLAUSE_MAP_TOFROM;
+      gcc_assert (!(flags & GOVD_MAP_TO_ONLY));
+      OMP_CLAUSE_MAP_KIND (clause) = OMP_CLAUSE_MAP_TOFROM;
+
       if (DECL_SIZE (decl)
 	  && TREE_CODE (DECL_SIZE (decl)) != INTEGER_CST)
 	{


GrÃÃe,
 Thomas

Attachment: pgps6D1FFS_Hp.pgp
Description: PGP signature

Follow-Ups:
- Re: Question about gimplify.c:gimplify_adjust_omp_clauses_1, GOVD_MAP_TO_ONLY
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]