This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [PATCH] Fix PR58115
- From: Bernd Edlinger <bernd dot edlinger at hotmail dot de>
- To: Jakub Jelinek <jakub at redhat dot com>, Richard Biener <richard dot guenther at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "rdsandiford at googlemail dot com" <rdsandiford at googlemail dot com>
- Date: Thu, 9 Jan 2014 10:36:43 +0100
- Subject: RE: [PATCH] Fix PR58115
- Authentication-results: sourceware.org; auth=none
- References: <87iotxv211 dot fsf at talisman dot default>,<20140106103000 dot GG892 at tucnak dot redhat dot com>,<f1eb6537-6c08-437c-9150-938fddf37d6e at email dot android dot com>,<DUB122-W13171ACEDEEC745B906363E4B70 at phx dot gbl>,<87eh4kvs2e dot fsf at talisman dot default>,<DUB122-W3371E3A0858FA6FEE57114E4B70 at phx dot gbl>,<87wqict2i0 dot fsf at talisman dot default>,<CAFiYyc0gEjjFx530yxQKa2zQ40wYKZTgYpy+mzyzX6JSnNNzdQ at mail dot gmail dot com>,<DUB122-W385E58BC9A893EE82EBF4DE4B00 at phx dot gbl>,<87lhypsf2z dot fsf at talisman dot default>,<20140109092843 dot GS892 at tucnak dot redhat dot com>
On Thu, 9 Jan 2014 10:28:43, Jakub Jelinek wrote:
>
> On Thu, Jan 09, 2014 at 09:02:28AM +0000, Richard Sandiford wrote:
>>> I think Jakub's patch will fix this case, but I did not try.
>>> However even if the i368 is now clean, there are
>>> still many targets that use target_reinit() in
>>> target_set_current_function.
>>
>> FWIW I only see three others (nios, rs6000 and rx). nios and rs6000
>> are direct cut-&-pastes of the i386 version so should be easy to switch.
>> rx looks more like MIPS in that it's switching between two specific
>> subtargets.
>
> Yeah, if i386 is changed into SWITCHABLE_TARGET, then I'd strongly encourage
> rs6000 and nios folks to follow the suit.
>
> Jakub
Ok for me. Hope they read this thread...
If that is our policy for 4.9.0, then the comment in function.c where
the targetm.set_current_function (fndecl); is called should
_very_ clearly say that this callback is no longer allowed to call
target_reinit() any more.
Thanks
Bernd.