This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [AArch64] big.LITTLE option rewriting bug
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: James Greenhalgh <james dot greenhalgh at arm dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, Marcus Shawcroft <Marcus dot Shawcroft at arm dot com>
- Date: Tue, 07 Jan 2014 17:11:54 +0000
- Subject: Re: [AArch64] big.LITTLE option rewriting bug
- Authentication-results: sourceware.org; auth=none
- References: <1387369385-1622-4-git-send-email-james dot greenhalgh at arm dot com> <1389114174-6745-1-git-send-email-james dot greenhalgh at arm dot com>
On 07/01/14 17:02, James Greenhalgh wrote:
>
> Ugh.
>
> Now we have two ASM_SPECs which try to handle -mcpu as input.
>
> One of them just returns the input, the other does the cpu rewriting
> we actually want, so we can end up with:
>
> gcc -mcpu=cortex-a57.cortex-a53
>
> Getting passed through to the assembler as:
>
> as -mcpu=cortex-a57 -mcpu=cortex-a57.cortex-a53
>
> Which is obviously broken.
>
> This patch removes the identity spec, the rewriting one will return
> identity for non-big.LITTLE names anyway.
>
> Checked with all the valid values of -mcpu to ensure that the right
> thing is passed through to the assembler. Also sanity checked with
> aarch64.exp.
>
> Ugh, and sorry, this was clumsy on my part.
>
> OK for trunk?
>
OK.
R.