This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Don't reject TER unnecessarily (PRs middle-end/58956, middle-end/59470)
- From: Hans-Peter Nilsson <hp at bitrange dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 23 Dec 2013 08:10:34 -0500 (EST)
- Subject: Re: [PATCH] Don't reject TER unnecessarily (PRs middle-end/58956, middle-end/59470)
- Authentication-results: sourceware.org; auth=none
- References: <20131212212513 dot GP892 at tucnak dot redhat dot com> <26fc127d-1e22-4ee9-820e-95ec647746b7 at email dot android dot com> <20131213073357 dot GR892 at tucnak dot redhat dot com> <f8ef6a8a-23ba-4f35-a900-9c60166119ab at email dot android dot com> <20131214110335 dot GZ892 at tucnak dot redhat dot com>
On Sat, 14 Dec 2013, Jakub Jelinek wrote:
> 2013-12-14 Jakub Jelinek <jakub@redhat.com>
>
> PR middle-end/58956
> PR middle-end/59470
> * gimple-walk.h (walk_stmt_load_store_addr_fn): New typedef.
> (walk_stmt_load_store_addr_ops, walk_stmt_load_store_ops): Use it
> for callback params.
> * gimple-walk.c (walk_stmt_load_store_ops): Likewise.
> (walk_stmt_load_store_addr_ops): Likewise. Adjust all callback
> calls to supply the gimple operand containing the base tree
> as an extra argument.
> * tree-ssa-ter.c: Include gimple-walk.h.
> (find_ssaname, find_ssaname_in_store): New helper functions.
> (find_replaceable_in_bb): For calls or GIMPLE_ASM, only set
> same_root_var if USE is used somewhere in the stores of the stmt.
> * ipa-prop.c (visit_ref_for_mod_analysis): Remove name of the stmt
> argument and ATTRIBUTE_UNUSED, add another unnamed tree argument.
> * ipa-pure-const.c (check_load, check_store, check_ipa_load,
> check_ipa_store): Likewise.
> * gimple.c (gimple_ior_addresses_taken_1, check_loadstore): Likewise.
> * ipa-split.c (test_nonssa_use, mark_nonssa_use): Likewise.
> (verify_non_ssa_vars, visit_bb): Adjust their callers.
> * cfgexpand.c (add_scope_conflicts_1): Use
> walk_stmt_load_store_addr_fn type for visit variable.
> (visit_op, visit_conflict): Remove name of the stmt
> argument and ATTRIBUTE_UNUSED, add another unnamed tree argument.
> * tree-sra.c (asm_visit_addr): Likewise. Remove name of the data
> argument and ATTRIBUTE_UNUSED.
> * cgraphbuild.c (mark_address, mark_load, mark_store): Add another
> unnamed tree argument.
> * gimple-ssa-isolate-paths.c (check_loadstore): Likewise. Remove
> ATTRIBUTE_UNUSED from stmt parameter.
Caused PR59584, an ICE.
(I'm going to fix the define_split bug that this exposed, but I
don't think that bug - allowing SP as a temporary - is the cause
of the hiccup.)
brgds, H-P