This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, i386] PR 59422 - Support more targets for function multi versioning
- From: Uros Bizjak <ubizjak at gmail dot com>
- To: Allan Sandfeld Jensen <carewolf at gmail dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "H.J. Lu" <hjl dot tools at gmail dot com>, Kirill Yukhin <kirill dot yukhin at gmail dot com>, "Gopalasubramanian, Ganesh" <Ganesh dot Gopalasubramanian at amd dot com>, Jakub Jelinek <jakub at redhat dot com>
- Date: Wed, 18 Dec 2013 14:49:42 +0100
- Subject: Re: [Patch, i386] PR 59422 - Support more targets for function multi versioning
- Authentication-results: sourceware.org; auth=none
- References: <CAFULd4bQV9=jQOZVQdTo2iCtzXgTJuqZX59NMDvfK7j7ZvubCA at mail dot gmail dot com> <CAFULd4bQWQtc_gigNon1u25=jY8AeoRMbkEKGBgg_Ekwo-UUjQ at mail dot gmail dot com> <201312171120 dot 41381 dot linux at carewolf dot com> <201312181357 dot 39664 dot linux at carewolf dot com>
On Wed, Dec 18, 2013 at 1:57 PM, Allan Sandfeld Jensen
<carewolf@gmail.com> wrote:
> Update patch. Solved __attribute((target("arch=corei7-avx"))) by defining
> proper architectures for the recent Intel families instead of renaming
> submodels.
@@ -30922,9 +30955,13 @@
F_SSE2,
F_SSE3,
F_SSSE3,
+ F_SSE4_a,
F_SSE4_1,
F_SSE4_2,
F_AVX,
+ F_FMA4,
+ F_XOP,
+ F_FMA,
F_AVX2,
F_MAX
and
@@ -89,9 +97,13 @@
FEATURE_SSE2,
FEATURE_SSE3,
FEATURE_SSSE3,
+ FEATURE_SSE4_a,
FEATURE_SSE4_1,
FEATURE_SSE4_2,
FEATURE_AVX,
+ FEATURE_FMA4,
+ FEATURE_XOP,
+ FEATURE_FMA,
FEATURE_AVX2
};
The above two enums should not be reordered.
> I am thinking the patch is starting to touch a bit many different details,
> perhaps it should be split up, or is it good as is?
It is OK.
Apart from the reordered enums, the patch looks mostly OK. Let's wait
a couple of days for possible comments from Intel and AMD people.
Uros.