This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PR tree-optimization/59149] fail on invalid arguments to flags_from_decl_or_type


On Thu, 12 Dec 2013, Aldy Hernandez wrote:

flags_from_decl_or_type() only handles a TYPE or DECL. Make this explicit instead.

I also added a check in the use in trans-mem.c, just in case. The subsequent conditionals should take care of the TM case.

It would be nice if Marc Glisse could provide the testcase he mentioned was failing. Either way, the attached patch doesn't hurt.

The failing testcases are already in the testsuite (I don't remember which ones, but there were quite a few IIRC). If you add only the gcc_unreachable and not the other part of your patch, you should see several failures.

--
Marc Glisse


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]