This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Handle PIEs in libbacktrace
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Dmitry Vyukov <dvyukov at google dot com>
- Cc: Ian Lance Taylor <iant at google dot com>, Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, Alexey Samsonov <samsonov at google dot com>
- Date: Fri, 6 Dec 2013 09:25:07 +0100
- Subject: Re: [PATCH] Handle PIEs in libbacktrace
- Authentication-results: sourceware.org; auth=none
- References: <20131206075033 dot GE892 at tucnak dot redhat dot com> <CACT4Y+b4Txm5oWOCEC71OmU5+4sbxgpkx=6ziiXD7DPfBrpeoA at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Fri, Dec 06, 2013 at 12:19:45PM +0400, Dmitry Vyukov wrote:
> > And the reason why check-g++ tsan.exp fails even with this patch is
> > that apparently tsan doesn't try to demangle the symbol names, so we get
> > e.g.:
>
> Demangling must be done by the symbolizer.
> +samsonov for this
So why does asan_report.cc have then:
static const char *MaybeDemangleGlobalName(const char *name) {
// We can spoil names of globals with C linkage, so use an heuristic
// approach to check if the name should be demangled.
return (name[0] == '_' && name[1] == 'Z')
? Symbolizer::Get()->Demangle(name)
: name;
}
and uses it where it wants to demangle? From what I can see, even when
you are using llvm-symbolizer, sanitizer_common doesn't pass -demangle
option to it.
Jakub