This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Time profiler - phase 2
- From: Jan Hubicka <hubicka at ucw dot cz>
- To: Martin Liška <marxin dot liska at gmail dot com>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 5 Dec 2013 22:32:06 +0100
- Subject: Re: [PATCH] Time profiler - phase 2
- Authentication-results: sourceware.org; auth=none
- References: <20131117190333 dot GA11338 at kam dot mff dot cuni dot cz> <CAObPJ3MqUhdybQ+Ua08ab680aoqXSAoq+tAfXi_xxkyYXzM2tg at mail dot gmail dot com> <20131117233727 dot GD2268 at kam dot mff dot cuni dot cz> <CAObPJ3OmMabfRtMFEFrUWddcYxnZ7VGeGE0CL=6bkQzdxF8vow at mail dot gmail dot com> <20131118101656 dot GA28536 at kam dot mff dot cuni dot cz> <CAObPJ3M7maO8FmJHMpKFv-sqr=ch=gUWRDKdBzyunmAYDfzpHw at mail dot gmail dot com> <CAObPJ3OKRZhb8UYEtvq3RPt3Xw_QzGEpx_vFjFGibtiLXZWSVQ at mail dot gmail dot com> <20131205133454 dot GA15832 at kam dot mff dot cuni dot cz> <20131205133845 dot GC15832 at kam dot mff dot cuni dot cz> <CAObPJ3MfLHJ0T-5puiLCKtagaySnP8AefLJjpZmCryCxCEhYnA at mail dot gmail dot com>
> Hello,
> thank you for the trick in ipa-split.c. It really helped! I
Good!, this patch is pre-approved after testing.
> prepared 2 tests for Inkscape, first was just with my function
> reordering pass. And for the second, I enable also
> -freorder-blocks-and-partition (note: files ending with _blocks.xxx in
> attached tar).
>
> Touched pages:
> just reorder functions: 1108
> with -freorder-blocks-and-partition: 1120
>
> Please see dumps at:
> https://drive.google.com/file/d/0B0pisUJ80pO1R19zSXR6U1Q4NmM/edit?usp=sharing
> Note: I put all function to a single section (for easier layout orientation).
I think for -freorder-blocks-and-partition you will need to split the sections
again, otherwise we will not see the effect of the pass. Can you, please, make
one extra systemtap with this (it would be good to have both
-fno-reorder-blocks-and-partition and -freorder-blocks-and-partition so we can
compare size of bloth)?
But overall it looks good!
Honza
>
> If I'm correct, there a small chunk of about 10 functions after the
> boundary of untouched functions and a single miss at the end of
> binary: __libc_csu_init.
> If you look at the graph line, it looks really well.
>
> I will prepare patch for mailing list as a phase 2.
>
> Martin
>
> On 5 December 2013 14:38, Jan Hubicka <hubicka@ucw.cz> wrote:
> >> Can you, please, send me the -flto systemtaps for gimp and/or inkscape so we can decide
> >> on the patch? We should enable it earlier in stage3 rather than later.
> >
> > I see, the PDF was included within the tar file. Was this with
> > -freorder-blocks-and-partition? If so, the patch is OK.
> > I still think we should put cold parts of hot/normal function into a subsection different
> > from unlikely section, but lets handle that incrementally.
> >
> > Thanks,
> > Honza
> >>
> >> Honza