This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch,avr]: Fix wrong warning PR59396
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Georg-Johann Lay <avr at gjlay dot de>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Denis Chertykov <chertykov at gmail dot com>, Eric Weddington <eric dot weddington at atmel dot com>
- Date: Thu, 5 Dec 2013 16:09:30 +0100
- Subject: Re: [Patch,avr]: Fix wrong warning PR59396
- Authentication-results: sourceware.org; auth=none
- References: <52A0937F dot 8020105 at gjlay dot de>
On Thu, Dec 5, 2013 at 3:53 PM, Georg-Johann Lay <avr@gjlay.de> wrote:
> This is a fix of a wrong warning for a bas ISR name. The assumption was
> that if DECL_ASSEMBLER_NAME is set, it would always starts with a *.
>
> This is not the case for LTO compiler where the assembler name is the plain
> name of the function (except an assembler name is set).
That sounds odd to me. Does the bug reproduce with -fwhole-program?
Or if the interrupt handler is static?
Richard.
> Thus, do a more restrictive test if the first character of the function name
> has to be skipped.
>
> Ok to commit?
>
> Johann
>
>
> PR target/59396
> * config/avr/avr.c (avr_set_current_function): If the first char
> of the function name is skipped, make sure it is actually '*'.