This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: libsanitizer merge from upstream r196090
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Konstantin Serebryany <konstantin dot s dot serebryany at gmail dot com>
- Cc: Uros Bizjak <ubizjak at gmail dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "H.J. Lu" <hjl dot tools at gmail dot com>, Dodji Seketeli <dodji at redhat dot com>, Marek Polacek <polacek at redhat dot com>, Dmitry Vyukov <dvyukov at google dot com>, Evgeniy Stepanov <eugenis at google dot com>, Alexey Samsonov <samsonov at google dot com>
- Date: Wed, 4 Dec 2013 14:02:32 +0100
- Subject: Re: libsanitizer merge from upstream r196090
- Authentication-results: sourceware.org; auth=none
- References: <CAFULd4ZrFy-o7GmDh31WRpoxiYwwLpaAY6pOtxCZ9i-+4kfv1A at mail dot gmail dot com> <CAGQ9bdzMRvFOWXmAbRoXAM4otn6JMR8AALspJ1s=hP=jgm7KXQ at mail dot gmail dot com> <CAFULd4Z-HrnYedyH_fcH1knQAD+=4jmC_xOBacgs2-DJhGWD0Q at mail dot gmail dot com> <20131202164412 dot GN892 at tucnak dot redhat dot com> <CAGQ9bdwJ3nePVREarj06mSpAc40LDGC37TXUVcKjbtQ3VSKH+A at mail dot gmail dot com> <20131202223259 dot GQ892 at tucnak dot redhat dot com> <CAGQ9bdz3juofpO8dCPPbagSN8NBad5_ig36nnPciR13P0Dm_hw at mail dot gmail dot com> <20131204082251 dot GM892 at tucnak dot redhat dot com> <CAGQ9bdwG7AqdnHTWRpmrEGMwE_MvhKes=9Qn7PVzpqHq9QmXAA at mail dot gmail dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Wed, Dec 04, 2013 at 04:49:22PM +0400, Konstantin Serebryany wrote:
> I would start from kernel version and glibc version, this should cover
> the majority of use cases.
Well, for the kernel headers what we perhaps can do is just add
libsanitizer/include/linux/ tree that will be maintained by GCC and will
contain (where needed) wrappers for kernel headers or their replacements
to make sure things compile, if you don't care about it in the compiler-rt
tree. But for the ppc32 stuff, we can't avoid modifying sanitizer_common
(the first patch I've posted recently, btw, I wonder if it works on sparc*,
we'll need to wait for somebody to test it), or e.g. for the .cfi_* stuff
(if you just apply the the .cfi_* related part of the patch I've posted
with say the macros __GCC_HAVE_* replaced by SANITIZER_USE_CFI_DIRECTIVES
or similar, I guess we can provide the right definition for that outside of
the compiler-rt maintained files.
Regarding the TLS size, can you e.g. just only do it for glibc 2.13 and
later, rather than having an (even for glibc 2.11/2.12 incorrect) values for
older glibcs?
Jakub