This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PING][PATCH] LRA: check_rtl modifies RTL instruction stream
- From: Alan Modra <amodra at gmail dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: Michael Meissner <gnu at the-meissners dot org>, gcc-patches at gcc dot gnu dot org, Robert Suchanek <Robert dot Suchanek at imgtec dot com>, Vladimir Makarov <vmakarov at redhat dot com>, David Edelsohn <dje dot gcc at gmail dot com>, Peter Bergner <bergner at vnet dot ibm dot com>
- Date: Tue, 3 Dec 2013 21:48:18 +1030
- Subject: Re: [PING][PATCH] LRA: check_rtl modifies RTL instruction stream
- Authentication-results: sourceware.org; auth=none
- References: <B5E67142681B53468FAF6B7C313565623D34C7AA at KLMAIL01 dot kl dot imgtec dot org> <528CFD09 dot 5070200 at redhat dot com> <20131128235008 dot GM9211 at bubble dot grove dot modra dot org> <529D7477 dot 1050602 at redhat dot com>
On Mon, Dec 02, 2013 at 11:04:39PM -0700, Jeff Law wrote:
> On 11/28/13 16:50, Alan Modra wrote:
> >
> >This is due to that innocuous seeming change of setting
> >lra_in_progress before calling check_rtl(), in combination with
> >previous changes Vlad made to the rs6000 backend here:
> >http://gcc.gnu.org/ml/gcc-patches/2013-10/msg02208.html
> >In particular the "Call legitimate_constant_pool_address_p in strict
> >mode for LRA" change, that sets "strict" when lra_in_progress.
> Is this still an issue?
No, the changes Vlad made fixed the powerpc problem. Thanks!
> That code has gone through a couple revisions. Robert's change was
> reverted and Vlad twiddled thigns to use recog_memoized instead of
> insn_invalid_p which prevents check_rtl from incorrectly adding
> CLOBBERs after the point where an insn's form is supposed to be
> fixed.
--
Alan Modra
Australia Development Lab, IBM