This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [buildrobot] [PATCH] mips: Really remove ENTRY_BLOCK_PTR
- From: Steven Bosscher <stevenb dot gcc at gmail dot com>
- To: Jan-Benedict Glaw <jbglaw at lug-owl dot de>
- Cc: David Malcolm <dmalcolm at redhat dot com>, gcc-patches at gcc dot gnu dot org, Richard Sandiford <rdsandiford at googlemail dot com>
- Date: Wed, 20 Nov 2013 10:08:45 +0100
- Subject: Re: [buildrobot] [PATCH] mips: Really remove ENTRY_BLOCK_PTR
- Authentication-results: sourceware.org; auth=none
- References: <20131120090429 dot GT30563 at lug-owl dot de>
On Wed, Nov 20, 2013 at 10:04 AM, Jan-Benedict Glaw wrote:
> 2013-11-20 Jan-Benedict Glaw <...>
>
> * config/mips/mips.c (r10k_simplify_address): Eliminate macro usage.
>
> diff --git a/gcc/config/mips/mips.c b/gcc/config/mips/mips.c
> index 82ca719..d06d574 100644
> --- a/gcc/config/mips/mips.c
> +++ b/gcc/config/mips/mips.c
> @@ -14842,7 +14842,7 @@ r10k_simplify_address (rtx x, rtx insn)
> /* Replace the incoming value of $sp with
> virtual_incoming_args_rtx. */
> if (x == stack_pointer_rtx
> - && DF_REF_BB (def) == ENTRY_BLOCK_PTR)
> + && DF_REF_BB (def) == ENTRY_BLOCK_PTR_FOR_FN (cfun))
> newx = virtual_incoming_args_rtx;
> }
> else if (dominated_by_p (CDI_DOMINATORS, DF_REF_BB (use),
>
>
> Ok?
>
> MfG, JBG
This patch is obvious and it fixes breakage. Please go ahead and commit it.
I wonder if there are any more cases like this missed... Could you
please check that? Something like:
egrep -w "ENTRY_BLOCK_PTR|EXIT_BLOCK_PTR" gcc/*.[ch] gcc/config/*.[ch]
gcc/config/*/*.{c,h,md}
should do the trick. (I'd do it myself if I had access to a Linux box
right now...)
Ciao!
Steven