This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Updated automated patch (was Re: [PATCH 3/6] Automated part of conversion of gimple types to use C++ inheritance)
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Andrew MacLeod <amacleod at redhat dot com>
- Date: Tue, 19 Nov 2013 10:51:55 -0500
- Subject: Re: [PATCH] Updated automated patch (was Re: [PATCH 3/6] Automated part of conversion of gimple types to use C++ inheritance)
- Authentication-results: sourceware.org; auth=none
- References: <5271CBF9 dot 2070005 at redhat dot com> <1383236801-13234-1-git-send-email-dmalcolm at redhat dot com> <1383236801-13234-4-git-send-email-dmalcolm at redhat dot com> <5284806A dot 2050607 at redhat dot com> <1384806352 dot 11568 dot 80 dot camel at surprise> <528AF38A dot 7080909 at redhat dot com>
On Mon, 2013-11-18 at 22:13 -0700, Jeff Law wrote:
> On 11/18/13 13:25, David Malcolm wrote:
> >
> > I regenerated it and am bootstrapping now. I glanced over it and
> > nothing major seems to have changed; just changes due to the movement of
> > code between files. Am attaching the changed patch.
> Yea, there's a lot of churn right now, so this is kind-of expected.
>
> Thanks for re-posting and verifying it's good to go. Never hurts to be
> careful.
>
> >
> > I think so, yes, though you'll have to cast it to the appropriate
> > subclass by hand; rather than the status quo of getting multiple
> > screenfuls of text, you'll just get the gimple_statement_base fields:
> Right. It's parsing the pages of text that I find to be a totally
> pointless waste of time. It's gotten worse, mostly because I was away
> for too long and I don't have the accessors in muscle-memory.
>
> WRT elimination of the GIMPLE_CHECKs, understood on the state of things
> and why the script didn't eliminate them in the various places I pointed
> out.
>
> This is fine. Please install.
Thanks; I've committed the combined patch series to trunk as r205034.