This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH 4/6] Implement is_a_helper <>::test specializations for various gimple types
- From: David Malcolm <dmalcolm at redhat dot com>
- To: Jeff Law <law at redhat dot com>
- Cc: gcc-patches at gcc dot gnu dot org, Andrew MacLeod <amacleod at redhat dot com>
- Date: Mon, 18 Nov 2013 13:54:01 -0500
- Subject: Re: [PATCH 4/6] Implement is_a_helper <>::test specializations for various gimple types
- Authentication-results: sourceware.org; auth=none
- References: <5271CBF9 dot 2070005 at redhat dot com> <1383236801-13234-1-git-send-email-dmalcolm at redhat dot com> <1383236801-13234-5-git-send-email-dmalcolm at redhat dot com> <52847D9D dot 3000801 at redhat dot com>
On Thu, 2013-11-14 at 00:37 -0700, Jeff Law wrote:
> On 10/31/13 10:26, David Malcolm wrote:
> > * gimple.h (is_a_helper <const gimple_statement_with_ops>::test): New.
> > (is_a_helper <gimple_statement_with_ops>::test): New.
> > (is_a_helper <const gimple_statement_with_memory_ops>::test): New.
> > (is_a_helper <gimple_statement_with_memory_ops>::test): New.
> OK with the usual conditions. Check with Andrew as to the location of
> these helpers since he's in the middle of ripping apart gimple.h.
The helpers become used in accessors such as gimple_use_ops,
gimple_vuse, gimple_vdef etc as of the automated patch (patch 3 in the
series [1]), so presumably the helpers need to be in the same file as
those accessors. The accessors are currently in gimple.h, and hence I
also put the helpers within gimple.h (earlier within the header).
Andrew, do you plan to move the accessor functions out of gimple.h? If
so, where should the is_a_helper fns land?
Dave
[1] hence these patches need to be committed at the same time, whether
than means a single "revision" or not; I split them up conceptually for
ease of review.