This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [1/10] Add tree_fits_shwi_p and tree_fits_uhwi_p


On Mon, Nov 18, 2013 at 11:50:45AM +0100, Richard Biener wrote:
> On Sat, Nov 16, 2013 at 1:55 PM, Richard Sandiford
> <rdsandiford@googlemail.com> wrote:
> > Add tree_fits_shwi_p and tree_fits_uhwi_p.  The implementations are taken
> > directly from host_integerp.
> 
> tree_ is a bit generic - you only ever return true for INTEGER_CSTs,
> so please use int_fits_[su]hwi_p please (mimicing int_fits_type_p).
> 
> Ok with that change.

I actually think tree_fits is better, int_fits* looks too ambiguous to me,
what kind of integer (tree, int, HWI, ...) you actually mean.
It also matches better say the preexisting tree_to_double_int.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]