This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: XFAIL a couple of gnat.dg testcases on MIPS
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Eric Botcazou <ebotcazou at adacore dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 13 Nov 2013 13:12:05 -0800
- Subject: Re: XFAIL a couple of gnat.dg testcases on MIPS
- Authentication-results: sourceware.org; auth=none
- References: <35552984 dot Dl31KDtAYV at polaris> <CAMe9rOr1GYunCpp+iZPEvrUE=ZwhHCL=jKnfPei4P8MAVZ8bSQ at mail dot gmail dot com>
On Wed, Nov 13, 2013 at 12:27 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Sun, Oct 21, 2012 at 1:26 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> They are reported as failing with the n32 ABI, but the failures are spurious.
>>
>> Tested on mips64el-linux-gnu, applied on the mainline and 4.7 branch.
>>
>>
>> 2012-10-21 Eric Botcazou <ebotcazou@adacore.com>
>>
>> * gnat.dg/specs/atomic1.ads: XFAIL on MIPS.
>> * gnat.dg/specs/addr1.ads: Likewise.
>>
>
> They are also failing on x32, which similar to n32:
>
> FAIL: gnat.dg/specs/addr1.ads (test for bogus messages, line 24)
> FAIL: gnat.dg/specs/atomic1.ads (test for errors, line 9)
> FAIL: gnat.dg/specs/atomic1.ads (test for errors, line 13)
>
Here is a patch. OK to install?
Thanks.
--
H.J.
2013-11-13 H.J. Lu <hongjiu.lu@intel.com>
* gnat.dg/specs/addr1.ads: XFAIL on x32.
* gnat.dg/specs/atomic1.ads: Likewise.
diff --git a/gcc/testsuite/gnat.dg/specs/addr1.ads b/gcc/testsuite/gnat.dg/specs/addr1.ads
index bcb833b..b357115 100644
--- a/gcc/testsuite/gnat.dg/specs/addr1.ads
+++ b/gcc/testsuite/gnat.dg/specs/addr1.ads
@@ -21,7 +21,7 @@ package Addr1 is
for Obj1'Address use A'Address; -- { dg-bogus "(alignment|erroneous)" }
Obj2: Rec2;
- for Obj2'Address use A'Address; -- { dg-bogus "(alignment|erroneous)" "" { xfail mips*-*-* } }
+ for Obj2'Address use A'Address; -- { dg-bogus "(alignment|erroneous)" "" { xfail mips*-*-* { { i?86-*-* x86_64-*-* } && x32 } } }
Obj3: Rec1;
for Obj3'Address use A(1)'Address; -- { dg-bogus "(alignment|erroneous)" }
diff --git a/gcc/testsuite/gnat.dg/specs/atomic1.ads b/gcc/testsuite/gnat.dg/specs/atomic1.ads
index 02e98b6..2994f2a 100644
--- a/gcc/testsuite/gnat.dg/specs/atomic1.ads
+++ b/gcc/testsuite/gnat.dg/specs/atomic1.ads
@@ -6,11 +6,11 @@ package Atomic1 is
type UA is access all Arr;
U : UA;
- pragma Atomic (U); -- { dg-error "atomic access" "" { xfail mips*-*-* } }
+ pragma Atomic (U); -- { dg-error "atomic access" "" { xfail mips*-*-* { { i?86-*-* x86_64-*-* } && x32 } } }
type R is record
U : UA;
- pragma Atomic (U); -- { dg-error "atomic access" "" { xfail mips*-*-* } }
+ pragma Atomic (U); -- { dg-error "atomic access" "" { xfail mips*-*-* { { i?86-*-* x86_64-*-* } && x32 } } }
end record;
end Atomic1;
--
1.8.3.1