This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Enhance ifcombine to recover non short circuit branches

From: Jeff Law <law at redhat dot com>
To: pinskia at gmail dot com, Steven Bosscher <stevenb dot gcc at gmail dot com>
Cc: Richard Biener <richard dot guenther at gmail dot com>, Zhenqiang Chen <zhenqiang dot chen at linaro dot org>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Fri, 08 Nov 2013 14:46:03 -0700
Subject: Re: [PATCH] Enhance ifcombine to recover non short circuit branches
Authentication-results: sourceware.org; auth=none
References: <CACgzC7AbQLh+uv=vzC51DiHjZZn12yEjvtrcyo61z7KjeYCe7Q at mail dot gmail dot com> <CA+=Sn1mm+3Zv9HxgGt4T_utu+-nsvhhCWRF-aWk05K=_704LRw at mail dot gmail dot com> <CAFiYyc2AgJg2r6mzQ69gYo2chBSRFgdVSkSnFU_tQXEanU+NGQ at mail dot gmail dot com> <52601731 dot 3000301 at redhat dot com> <CACgzC7BjGmkTZbor8Jr8ZpjN08JZUy-V64ExukG6HozK45=krw at mail dot gmail dot com> <CA+=Sn1nTd97wm7aWTmwKskZqzQZqC-a3cxW+p7GUH=CTnYTs-A at mail dot gmail dot com> <CA+=Sn1kZFa=+HRbk1kZZomX_rmujL=n+ZVqxEmtF6qvKpsYHUQ at mail dot gmail dot com> <CA+=Sn1k14xfavt02=1G4RWjdHC6BCvMpG0TrO5FKUEbxs6gkkA at mail dot gmail dot com> <CAFiYyc2o8r+iHzJLHmzRknVWR6o67uX_ZEPRV8sV-2UjBuHtkA at mail dot gmail dot com> <CA+=Sn1ktsHUWVzQ192Z4iLs-ZsNtJpw9QCzcH6ASrhVnBSw9mw at mail dot gmail dot com> <CABu31nMe435fvrCGQWsQRnLnbD+O7OTSvBBUStOQk44YEq56hQ at mail dot gmail dot com> <61F648BF-FFE8-4DA5-B1A0-5A41BA247561 at gmail dot com>

On 11/08/13 10:45, pinskia@gmail.com wrote:

On Nov 8, 2013, at 9:20 AM, Steven Bosscher <stevenb.gcc@gmail.com>
wrote:

On Wed, Oct 30, 2013 at 5:03 AM, Andrew Pinski wrote: Here is
what I applied in the end; Jeff told me just to remove the
testcase.  I added the comment trying to explain why it was the
opposite order of PHI-opt.

Thanks, Andrew Pinski

ChangeLog: * tree-ssa-ifcombine.c: Include rtl.h and tm_p.h.


Eh, why???

The file has this comment:

25    /* rtl is needed only because arm back-end requires it for 26
BRANCH_COST.  */ 27    #include "rtl.h" 28    #include "tm_p.h"

Can you please clarify why this is not something to be fixed in
the ARM back end?


Really BRANCH_COST should be a target hook rather than a macro which
should fix this issue.  fold-const.c has the same include for the
same reason.  I thought I had saw a patch which changes it into a
hook. Next week if I get time, I will do that.  I knew it was the
wrong direction which is why I added a comment.

Also note that other patches have gone in recently which include thosefiles for exactly the same reason. I don't think Andrew did anythingwrong here.

Clearly those can/should/will go away when BRANCH_COST turns into atarget hook. I'd like to do it myself, but I'm buried right now.


jeff

Follow-Ups:
- Re: [PATCH] Enhance ifcombine to recover non short circuit branches
  - From: Steven Bosscher

References:
- Re: [PATCH] Enhance ifcombine to recover non short circuit branches
  - From: Steven Bosscher
- Re: [PATCH] Enhance ifcombine to recover non short circuit branches
  - From: pinskia

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]