[gomp4] rewrite simd clone argument adjustment to avoid regimplification

[Aldy Hernandez <aldyh at redhat dot com>]

On 11/04/13 08:44, Jakub Jelinek wrote:
> I guess short time yes, but I wonder if it wouldn't be better to use
> walk_gimple_op and do all changes in the callback.  Instead of passing
> adjustments pass around a struct containing the adjustments, current stmt
> and the modified flag.  You can use the val_only and is_lhs to determine
> what you need to do (probably need to reset those two for the subtrees
> to val_only = true, is_lhs = false and not walk subtrees of types) and you
> could (if not val_only) immediately gimplify it properly (insert temporary
> SSA_NAME setter before resp. store after depending on is_lhs).
> Then you could avoid the regimplification.

With the attached patch, we get rid of the ad-hoc argument adjustment 
system that is in place, and avoid regimplification altogether.  I am 
using walk_gimple_op as suggested, thus cleaning up most of 
ipa_simd_modify_function_body.

I have checked the following patch with the attached testcases that were 
previously ICEing, and with a handful of handcrafted tests that I 
checked manually (array references on lhs and rhs, vectors of pointers, 
etc).

OK for branch?

Attachment: curr
Description: Text document