This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH C++/testsuite] Remove pchtest check objects and compile with current tool
- From: Mike Stump <mikestump at comcast dot net>
- To: Bernhard Reutner-Fischer <rep dot dot dot nop at gmail dot com>
- Cc: jason at redhat dot com, janis_johnson at mentor dot com, paolo dot carlini at oracle dot com, gcc-patches at gcc dot gnu dot org, libstdc++ at gcc dot gnu dot org
- Date: Wed, 30 Oct 2013 14:47:47 -0700
- Subject: Re: [PATCH C++/testsuite] Remove pchtest check objects and compile with current tool
- Authentication-results: sourceware.org; auth=none
- References: <20131030095618 dot GB22154 at nbbrfq dot cc dot univie dot ac dot at>
On Oct 30, 2013, at 2:56 AM, Bernhard Reutner-Fischer <rep.dot.nop@gmail.com> wrote:
> - set result [check_compile pchtest object "int i;" "-x c-header"]
> + set result [check_compile pchtest object "$chk_type" "$chk_lang"]
the patch uses chk_type, but, I can't find where it is being set?
Was there a significant purpose for the added C++ comment? If not, can you remove that? If so, can you explain?
Last question I have is the remove-build-file primitive. I'm wondering on a canadian cross, are the files left over on the build machine, the host machine or both the build machine and the host machine?
I see people use remote_file build delete …, file_on_host delete and remove-build-file. Some folks even use the plain file delete. I'd hate to guess which one you need, it hurts my brain. I think remove-build-file is safe; just don't know if it is best. Anyone else want to weigh in?