This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Flatten tree-ssa-loops.h
- From: Diego Novillo <dnovillo at google dot com>
- To: Andrew MacLeod <amacleod at redhat dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Richard Biener <richard dot guenther at gmail dot com>, Jeff Law <law at redhat dot com>
- Date: Wed, 23 Oct 2013 10:35:54 -0400
- Subject: Re: [patch] Flatten tree-ssa-loops.h
- Authentication-results: sourceware.org; auth=none
- References: <5267DCBC dot 2030908 at redhat dot com>
On Wed, Oct 23, 2013 at 10:27 AM, Andrew MacLeod <amacleod@redhat.com> wrote:
> Similar to tree-ssa.h, tree-ssa-loops.h became an aggregator for 3 of the
> tree-ssa-loop* header files. This remedies that situation.
>
> The average .c file required only 1 of the 3 includes from tree-ssa-loop.h.
>
> Bootstraps on x86_64-unknown-linux-gnu (with graphite enabled :-).
> Regressions are running, but I expect no issues due to this just being just
> an include shuffle.
Looks OK.
What do you think about Jan-Benedict's idea of installing a commit
hook that would check that no #includes of certain headers get into
other headers? We could just leave this to code reviews, but perhaps
installing a hook makes it easier.
Diego.