This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Ilya Enkovich <enkovich dot gnu at gmail dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 21 Oct 2013 12:08:14 +0000
- Subject: Re: [PATCH, MPX, 2/X] Pointers Checker [2/25] Builtins
- Authentication-results: sourceware.org; auth=none
- References: <20131021114918 dot GB37888 at msticlxl57 dot ims dot intel dot com>
On Mon, 21 Oct 2013, Ilya Enkovich wrote:
> + if (flag_check_pointers)
> + {
> + if (flag_lto)
> + sorry ("Pointers checker is not yet fully supported for link-time optimization");
That sounds wrong. It suggests some bug somewhere in your patch series
failing to allow for LTO, which should be fixed. At least give a more
detailed explanation in a comment of what would need to change to remove
this call to sorry ().
> + if (targetm.chkp_bound_mode () == VOIDmode)
> + error ("-fcheck-pointers is not supported for this target.");
Also note GNU Coding Standards for diagnostics. They should not start
with uppercase letters or end with ".".
--
Joseph S. Myers
joseph@codesourcery.com