This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][i386]Fix PR 57756
- From: Sriraman Tallam <tmsriram at google dot com>
- To: Dominique Dhumieres <dominiq at lps dot ens dot fr>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Mike Stump <mikestump at comcast dot net>
- Date: Fri, 18 Oct 2013 10:27:04 -0700
- Subject: Re: [PATCH][i386]Fix PR 57756
- Authentication-results: sourceware.org; auth=none
- References: <20131018100316 dot B1F60106 at mailhost dot lps dot ens dot fr>
On Fri, Oct 18, 2013 at 3:03 AM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
> Sriraman,
>
> The tests gcc.target/i386/funcspec-5.c and gcc.target/i386/pr57756.c fail
> on targets for which -msse is the default (see
> http://gcc.gnu.org/ml/gcc-testresults/2013-10/msg01365.html or
> http://gcc.gnu.org/ml/gcc-testresults/2013-10/msg01345.html ).
pr57756.c is reported failing on x86_64-unknown-linux-gnu and I am
using the same config. I have both tests passing. What am I missing? I
do not see why pr57756 should be marked with -mno-sse.
Sri
>
> This is fixed with the following patch:
>
> diff -up ../_clean/gcc/testsuite/gcc.target/i386/funcspec-5.c gcc/testsuite/gcc.target/i386/funcspec-5.c
> --- ../_clean/gcc/testsuite/gcc.target/i386/funcspec-5.c 2011-08-23 21:54:27.000000000 +0200
> +++ gcc/testsuite/gcc.target/i386/funcspec-5.c 2013-10-17 09:45:20.000000000 +0200
> @@ -2,6 +2,7 @@
> without error. */
> /* { dg-do compile } */
> /* { dg-require-effective-target ia32 } */
> +/* { dg-options "-mno-sse" } */
>
> extern void test_abm (void) __attribute__((__target__("abm")));
> extern void test_aes (void) __attribute__((__target__("aes")));
> diff -up ../_clean/gcc/testsuite/gcc.target/i386/pr57756.c gcc/testsuite/gcc.target/i386/pr57756.c
> --- ../_clean/gcc/testsuite/gcc.target/i386/pr57756.c 2013-10-15 23:53:31.000000000 +0200
> +++ gcc/testsuite/gcc.target/i386/pr57756.c 2013-10-17 09:46:53.000000000 +0200
> @@ -1,6 +1,7 @@
> /* callee cannot be inlined into caller because it has a higher
> target ISA. */
> /* { dg-do compile } */
> +/* { dg-options "-mno-sse" } */
>
> __attribute__((always_inline,target("sse4.2")))
> __inline int callee () /* { dg-error "inlining failed in call to always_inline" } */
>
> My apologies if this has already reported in the thread (I may have missed some posts).
>
> Dominique