Re: [PATCH][i386]Fix PR 57756

[Jan-Benedict Glaw <jbglaw at lug-owl dot de>]

On Wed, 2013-10-16 19:40:21 -0700, Xinliang David Li <davidxl@google.com> wrote:
> On Wed, Oct 16, 2013 at 6:06 PM, David Edelsohn <dje.gcc@gmail.com> wrote:
> > On Wed, Oct 16, 2013 at 7:23 PM, Sriraman Tallam <tmsriram@google.com> wrote:
> > > I was unable to build a native powerpc compiler. I checked for
> > > build_target_node and build_optimization_node throughout and
> > > changed rs6000 because it had references. I did not realize
> > > function_specific_save and function_specific_restore have to be
> > > changed. Sorry for breaking it.
> >
> > As Mike replied, gcc110 is available.  Richard Biener's approval
> > was dependent upon successful bootstrap and passing the regression
> > testsuite, which you did not even attempt, nor did you try to
> > build a cross-compiler.
> 
> This is an oversight. I agree that it is better to test on multiple
> platforms for large changes like this. In the past, Sri has been
> very attentive to any fallouts due to his changes, so is this time.

As of speaking about multiple platforms...  This patch didn't only
produce fallout on rs6k, but also for quite a number of other
architectures.

  I already send one message (it can be found in the archives at
http://gcc.gnu.org/ml/gcc-patches/2013-10/msg01156.html) listing quite
a number of targets that are broken right now. This situation didn't
change significantly since they started to fail. Please have a look at
my build robot[1]. All targets (except nds32, nios2 and arceb) used to
build.

  Don't get me wrong. I don't want to overly blame Sriraman for
breaking it in the first place. Shit happens. But please have an eye
on fixing the fallout, timely.

MfG, JBG
[1] http://toolchain.lug-owl.de/buildbot/?limit=2000

-- 
      Jan-Benedict Glaw      jbglaw@lug-owl.de              +49-172-7608481
Signature of:           Ich hatte in letzter Zeit ein biÃchen viel Realitycheck.
the second  :               Langsam mÃchte ich mal wieder weitertrÃumen kÃnnen.
                             -- Maximilian Wilhelm (18. Mai 2005, #lug-owl.de)

Attachment: signature.asc
Description: Digital signature