This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH][i386]Fix PR 57756
- From: Michael Meissner <meissner at linux dot vnet dot ibm dot com>
- To: Sriraman Tallam <tmsriram at google dot com>
- Cc: Michael Meissner <meissner at linux dot vnet dot ibm dot com>, GCC Patches <gcc-patches at gcc dot gnu dot org>, David Edelsohn <dje at gcc dot gnu dot org>, David Li <davidxl at google dot com>
- Date: Wed, 16 Oct 2013 19:33:10 -0400
- Subject: Re: [PATCH][i386]Fix PR 57756
- Authentication-results: sourceware.org; auth=none
- References: <CAFiYyc2y5-6j5wqhgz30y4ZvZgMvekPwxTdxy7kt_0s=rpD+CA at mail dot gmail dot com> <CAAs8HmzaRuskG1AcVEmiYuVQCNzXp8kjY5oMTTdhhDhG5juJ5g at mail dot gmail dot com> <CAAs8Hmy7bU2fMRqtRUiX76EEe4Ma8NBdnPsbWCAJz5zAof8oLg at mail dot gmail dot com> <CAAs8Hmy0H4VB-0mJx_4=OE1eyMbSm7Lo40kcWi42CQzymtYU4Q at mail dot gmail dot com> <CAFULd4YguDhSbUtoEU+Qw60HoKkw+64s9hEJTcAv-9dGxdOy+Q at mail dot gmail dot com> <CAAs8Hmxt8TEN8ZWF1WuhHkTY9faa1wH12FtHUJOVa-UTm54D0Q at mail dot gmail dot com> <20131016055411 dot GJ20756 at bubble dot grove dot modra dot org> <CAAs8HmyL=7ZgsiPGK=ZUh6j3PWudi3i_FObR3_0Yr3YkBfVBXw at mail dot gmail dot com> <20131016231314 dot GA16300 at ibm-tiger dot the-meissners dot org> <CAAs8HmzdmE1w9hGzR4BVo9dFw9JkuUiJ7j1SNXYYXrAh+9J50Q at mail dot gmail dot com>
On Wed, Oct 16, 2013 at 04:23:56PM -0700, Sriraman Tallam wrote:
> On Wed, Oct 16, 2013 at 4:13 PM, Michael Meissner
> <meissner@linux.vnet.ibm.com> wrote:
> > On Wed, Oct 16, 2013 at 02:34:56PM -0700, Sriraman Tallam wrote:
> >> On Tue, Oct 15, 2013 at 10:54 PM, Alan Modra <amodra@gmail.com> wrote:
> >> > On Tue, Oct 15, 2013 at 02:45:23PM -0700, Sriraman Tallam wrote:
> >> >> I committed this patch after making the above change.
> >> >
> >> > /src/gcc-virgin/gcc/config/rs6000/rs6000.c: At global scope:
> >> > /src/gcc-virgin/gcc/config/rs6000/rs6000.c:31122:29: error: invalid conversion from âvoid (*)(cl_target_option*)â to âvoid (*)(cl_target_option*, gcc_options*)â [-fpermissive]
> >> > /src/gcc-virgin/gcc/config/rs6000/rs6000.c:31122:29: error: invalid conversion from âvoid (*)(cl_target_option*)â to âvoid (*)(gcc_options*, cl_target_option*)â [-fpermissive]
> >>
> >> This patch fixes it, ok to submit?
> >
> > No. I have just committed a fix for this. Your patch does not replicate the
> > rs6000_isa_flags_explicit field to be a GCC option. Presumably the intent of
> > the 57756 patch was to remove references to the global variables. Your patch
> > still references those variables. What I did was to move the isa explicit flag
> > to be a target variable, so that it is preserved in the gcc_options structure
> > like everything else.
> >
> > However, I wonder why you committed the original changes with changes to the
> > powerpc backend, and DID NOT build a powerpc and fix the compilation errors.
>
> I was unable to build a native powerpc compiler. I checked for
> build_target_node and build_optimization_node throughout and changed
> rs6000 because it had references. I did not realize
> function_specific_save and function_specific_restore have to be
> changed. Sorry for breaking it.
The gcc110 machine in the compile farm can be used to build native powerpc64
toolchains. In addition, the problem would have shown up if you had built a
cross compiler.
You presumably missed the references in rs6000.h that defined
rs6000_isa_flags_explicit as using the global_options_set structure.
--
Michael Meissner, IBM
IBM, M/S 2506R, 550 King Street, Littleton, MA 01460, USA
email: meissner@linux.vnet.ibm.com, phone: +1 (978) 899-4797