This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] tree_code_name wrapper
- From: Jakub Jelinek <jakub at redhat dot com>
- To: Paulo Matos <pmatos at broadcom dot com>
- Cc: Richard Biener <richard dot guenther at gmail dot com>, Paolo Carlini <paolo dot carlini at oracle dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Tue, 15 Oct 2013 11:50:55 +0200
- Subject: Re: [PATCH] tree_code_name wrapper
- Authentication-results: sourceware.org; auth=none
- References: <19EB96622A777C4AB91610E763265F462DC5C7 at SJEXCHMB14 dot corp dot ad dot broadcom dot com> <525C1786 dot 5030404 at oracle dot com> <CAFiYyc0b7fU=L28_rkfo4x0zQ-wkf=tr+APMuXd3DVNw5FGAHQ at mail dot gmail dot com> <19EB96622A777C4AB91610E763265F462DC8D3 at SJEXCHMB14 dot corp dot ad dot broadcom dot com>
- Reply-to: Jakub Jelinek <jakub at redhat dot com>
On Tue, Oct 15, 2013 at 09:42:17AM +0000, Paulo Matos wrote:
> Thanks, regarding the indentation I was convinced we used 2 space
> indentation with maximum line length of 80 characters.
We do, however 8 consecutive spaces in the indentation should be always
replaced by a tab.
> Should I also submit several change logs to gcc-patches like:
>
> For gcc/
> 2013-10-15 Paulo Matos <pmatos@broadcom.com>
>
> * ...
>
> For gcc/cp/
> 2013-10-15 Paulo Matos <pmatos@broadcom.com>
>
> * ...
If you touch just one ChangeLog file, just make the paths relative
to it's location (i.e. post what you will actually commit to the
ChangeLog file). Otherwise, either you can post multiple ChangeLog
entries as you write above, or just one date name email line
and
gcc/
* ...
gcc/cp/
* ...
or similar, then the individual pieces will be again the final text
you put into the ChangeLog and just add the leading line there.
In either way the reviewer can immediately see you do not mean to
put everything into one ChangeLog or keep the path prefixes that shouldn't
be added during your commit.
Jakub