Re: [C++ Patch] PR 58633

[Paolo Carlini <paolo dot carlini at oracle dot com>]

Hi,

On 10/10/2013 08:48 PM, Jason Merrill wrote:
> > I think that committing was important for two primary reasons:
> >
> >  1. We should not have irreversible side-effects while in a tentative
> >     state.  For example, we shouldn't create a permanent entry in the
> >     symbol table, or issue an error message that might not apply if the
> >     tentative parse is aborted.  The "tentative" stuff is only in the
> >     parser; there's no easy way to remove a function or variable from
> >     the symbol table, or undo other pieces of global state in the
> >     compiler as a whole.
>
> Right.  In cases where there aren't side-effects, this shouldn't be an 
> issue.  We should only use Paolo's new function in such cases; Paolo, 
> please add that to the comment.  The patch is OK with that change.
Thanks. Thus I'm finishing testing the below.

The issue is a regression in 4_7/4_8 too, what should we do in those 
branches? I'm thinking applying the change to 4_8 too and either not 
fixing in 4_7 or just reverting the cp_parser_commit_to_tentative_parse 
change which improved the diagnostic for 47277?

Thanks,
Paolo.

///////////////////////

Attachment: CL_58633_4
Description: Text document

Attachment: patch_58633_4
Description: Text document