This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [C++ Patch] PR 31671


Hi,

On 10/10/2013 08:26 PM, Jason Merrill wrote:
On 10/10/2013 08:33 AM, Paolo Carlini wrote:
+          expr_type = TREE_TYPE (expr) = cp_build_qualified_type
+        (TREE_TYPE (expr), cp_type_quals (TREE_TYPE (probe_type)));

Won't that end up being the same as the contents of expr_type before this statement? Can we just remove this assignment?

Also, clobbering TREE_TYPE (expr) strikes me as a bad idea.
Sorry. Having figured out where the problem was, I messed up very badly when I prepared the actual patch for submission. The below makes much more sense to me.

Thanks,
Paolo.

////////////////////

Attachment: CL_31671_2
Description: Text document

Attachment: patch_31671_2
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]