Re: [C++ Patch] PR 58584

[Paolo Carlini <paolo dot carlini at oracle dot com>]

Hi,

On 10/03/2013 04:02 PM, Jason Merrill wrote:
> On 10/02/2013 09:02 PM, Paolo Carlini wrote:
> > -      save_template_attributes (&attributes, decl);
> > +      if (attributes != error_mark_node)
> > +    save_template_attributes (&attributes, decl);
>
> I'd rather make save_template_attributes handle error_mark_node 
> appropriately.
>
> > +  if (attributes != error_mark_node)
> > +    cp_check_const_attributes (attributes);
>
> Likewise.
Indeed. It occurred to me that we may have preferred this solution, 
consistent with most of other places where we handle error_mark_node. I 
hesitated only because the helpers are called only from that one place.

Anyway, I tested the below.

Thanks,
Paolo.

////////////////////

Attachment: CL_58584_2
Description: Text document

Attachment: patch_58584_2
Description: Text document