This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Make the 2 versions of delete more similar
- From: Christopher Jefferson <chris at bubblescope dot net>
- To: Marc Glisse <marc dot glisse at inria dot fr>
- Cc: "libstdc++" <libstdc++ at gcc dot gnu dot org>, gcc-patches at gcc dot gnu dot org
- Date: Wed, 2 Oct 2013 13:42:23 +0100
- Subject: Re: Make the 2 versions of delete more similar
- Authentication-results: sourceware.org; auth=none
- References: <alpine dot DEB dot 2 dot 02 dot 1310021043470 dot 13176 at stedding dot saclay dot inria dot fr>
On 2 October 2013 13:28, Marc Glisse <marc.glisse@inria.fr> wrote:
> Hello,
>
> I don't understand why those 2 files differ by more than 1 extra argument,
> so I am changing that.
>
> Bootstrap and testsuite on x86_64.
>
> 2013-10-03 Marc Glisse <marc.glisse@inria.fr>
>
> * libsupc++/del_op.cc (operator delete): Don't test for 0 before
> free.
Just checking, for the nervous:
Is the plan that this change will not effect any code behaviour (as
correct implementations of free are happy to take a NULL pointer, and
not do anything)?
Chris
> _GLIBCXX_WEAK_DEFINITION void
> operator delete(void* ptr) _GLIBCXX_USE_NOEXCEPT
> {
> - if (ptr)
> - std::free(ptr);
> + std::free(ptr);
> }