This is the mail archive of the
mailing list for the GCC project.
Re: [patch] move htab_iterator
- From: Tom Tromey <tromey at redhat dot com>
- To: Andrew MacLeod <amacleod at redhat dot com>
- Cc: gcc-patches <gcc-patches at gcc dot gnu dot org>, Richard Biener <richard dot guenther at gmail dot com>, Jakub Jelinek <jakub at redhat dot com>
- Date: Mon, 30 Sep 2013 11:02:06 -0600
- Subject: Re: [patch] move htab_iterator
- Authentication-results: sourceware.org; auth=none
- References: <52499D4C dot 1040507 at redhat dot com> <8761tib8c9 dot fsf at fleche dot redhat dot com> <5249A4B7 dot 801 at redhat dot com>
Tom> How about putting it into libiberty?
Tom> That way other hashtab users, like gdb, can use it.
Andrew> I have no problem with that, but Jakub didn't seem to think it
Andrew> belonged there.
All I found was this:
Quoting from it: "It doesn't belong to hashtab.h, because that is a
libiberty API, this style of iterators is GCC specific."
I think that's an accurate assessment of the current code, but I don't
see why it has to continue to be that way.
My argument in favor of moving it to libiberty is that other programs
can then use it; and furthermore that since it is tightly tied to the
hashtab implementation, it ought to be maintained there in order to
preserve the module boundary.
So, please reconsider.