This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Trivial cleanup
- From: Jeff Law <law at redhat dot com>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>
- Cc: Andrew MacLeod <amacleod at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 25 Sep 2013 09:59:41 -0600
- Subject: Re: [PATCH] Trivial cleanup
- Authentication-results: sourceware.org; auth=none
- References: <5243025E dot 8050101 at redhat dot com> <52430544 dot 8030005 at redhat dot com> <524305C3 dot 3050003 at oracle dot com>
On 09/25/2013 09:48 AM, Paolo Carlini wrote:
Yea. I actually reviewed the libstdc++ guidelines to see where they
differed from GNU's C guidelines.
On 9/25/13 10:46 AM, Andrew MacLeod wrote:
I was going to bring it up at some point too. My preference is
strongly to simply eliminate the space on methods...
Which wouldn't be so weird: in the libstdc++-v3 code we do it all the time.
I'm strongly in favor of dropping the horizontal whitespace between the
method name and its open paren when the result is then dereferenced. ie
foo.last()->e rather than foo.last ()->e.
However, do we want an exception when the result isn't immediately
dereferenced? ie, foo.last () or foo.last()?