This is the mail archive of the
mailing list for the GCC project.
Re: [patch] Make vector::at() assertion message more useful (try #2)
- From: Marc Glisse <marc dot glisse at inria dot fr>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>
- Cc: Andreas Schwab <schwab at suse dot de>, Paul Pluzhnikov <ppluzhnikov at google dot com>, gcc-patches List <gcc-patches at gcc dot gnu dot org>, libstdc++ <libstdc++ at gcc dot gnu dot org>
- Date: Mon, 23 Sep 2013 15:55:26 +0200 (CEST)
- Subject: Re: [patch] Make vector::at() assertion message more useful (try #2)
- Authentication-results: sourceware.org; auth=none
- References: <ye6qhae0qpf8 dot fsf at elbrus2 dot mtv dot corp dot google dot com> <CAGNvRgDfHf6pYmBYC66HHhj6RobhiaiAAVEKj1FDxSWGxbYFTg at mail dot gmail dot com> <CALoOobMf3u8R_DVW5b2eRy05fBpB5unhriLMYdUEkT_E3DwtaA at mail dot gmail dot com> <CAGNvRgD6mK=-n7QhK=-NtfXZHOpCniXKc-riWUNfqZeVa8xufQ at mail dot gmail dot com> <CALoOobO6XEsrSM6jJFCQ=n00iY8qM=eujs-=LixNZyuya5f-cA at mail dot gmail dot com> <5232E2AF dot 4000106 at oracle dot com> <CALoOobMejGJLVVCszP8Joa+4B21UbvK4chyFUnjiCNPP0GJF0A at mail dot gmail dot com> <mvma9j35377 dot fsf at hawking dot suse dot de> <52402567 dot 2080407 at oracle dot com> <mvm1u4f4v81 dot fsf at hawking dot suse dot de> <11cc3fe3-a8b9-43ff-a614-d4f374447236 at email dot android dot com>
- Reply-to: libstdc++ at gcc dot gnu dot org
On Mon, 23 Sep 2013, Paolo Carlini wrote:
There are a lot of targets using unsigned int for size_t, which would
have been uncovered by proper testing.
We can't test all patches on 3-4 different targets... It wasn't obvious
this patch could be that sensitive to the target.
That's true, just remember to test *both* -m32 and -m64, for non trivial
So how do you do that in practiceÂ? Is it done by default if multilib is
enabled? You also mentioned doing something special to check debug/profile
modes recently, is there a make target to really perform all the tests
necessary for a submission?
http://gcc.gnu.org/contribute.html has an outdated section on testing. It
mentions that you should do a bootstrap for a change to the C front-end
(should also be for the C++ front-end and I guess libstdc++ even if it
isn't used much inside gcc).