This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

RE: [PR58463] New testcase for pr58463

> -----Original Message-----
> From: Jakub Jelinek []
> Sent: 20 September 2013 16:50
> To: Paulo Matos
> Cc:
> Subject: Re: [PR58463] New testcase for pr58463
> That is not the right place (and, note the ChangeLog entry refers to a
> different path than the testcase, and doesn't have space before <.), such
> test should go into gcc.dg/.  But, more importantly, the test doesn't
> cleanup after itself.  I bet it is enough to test just one dump that
> was actually crashing rather than all of them, so please change that
> to -fdump-tree-<whateverpass>-all and add corresponding:
> /* { dg-final { cleanup-tree-dump "<whateverpass>" } } */
> line.  Or, if you really want to test more than one pass dump, add
> the individual -fdump-tree-pass1-all -fdump-tree-otherpass2-all
> and corresponding cleanup-tree-dump lines for each of them.  I don't think
> there is a way to get all dumps cleaned up.
> 	Jakub

Thanks for all your comments Jakub, I will format a new patch and submit it under a new thread.

Paulo Matos

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]