This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Make vector::at() assertion message more useful (try #2)



Hi

Andreas Schwab <schwab@suse.de> ha scritto:

>What's wrong with always adding the instantiation?

That quite a few targets will not use it and will remain dead in the .so? But I agree that it's an option, that you can also pursue immediately if you like, also preapproved (I'm traveling, either you or Paul or somebody else has to do the work, sorry)

>
>> but would work I think. In any case, if it works for Andreas he is
>> also preapproved to commit this kind change to unbreak his target.
>
>There are a lot of targets using unsigned int for size_t, which would
>have been uncovered by proper testing.

That's true, just remember to test *both* -m32 and -m64, for non trivial changes. How many times I have to repeat that?

Paolo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]