This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] PR 58355: [4.7/4.8/4.9 Regression] [F03] ICE with TYPE, EXTENDS before parent TYPE defined
- From: Janus Weil <janus at gcc dot gnu dot org>
- To: Paul Richard Thomas <paul dot richard dot thomas at gmail dot com>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 23 Sep 2013 09:44:11 +0200
- Subject: Re: [Patch, Fortran] PR 58355: [4.7/4.8/4.9 Regression] [F03] ICE with TYPE, EXTENDS before parent TYPE defined
- Authentication-results: sourceware.org; auth=none
- References: <CAKwh3qjmu2QROALr8E=9_yzkWv5L9OEOAj8pKdnSHGo+f6bqrQ at mail dot gmail dot com> <CAGkQGiL2kYTrur1n0UqOMhuxCUXxYpnNcKOR2QKao85xb57joA at mail dot gmail dot com>
Hi Paul,
> This is OK for trunk and, in my opinion, for back-porting in its entirity.
>
> Thanks for the patch
thanks for the review! Committed to trunk as r202823. Will do the
backports soon.
Also: Nice to hear from you! It's been a while ... :)
Cheers,
Janus
> On 21 September 2013 16:31, Janus Weil <janus@gcc.gnu.org> wrote:
>> Hi all,
>>
>> the straightforward patch in the attachment does two things:
>>
>> 1) It prevents a segfault, which is a regression on 4.7/4.8/trunk (by
>> simply switching the order of two statements).
>> 2) It modifies an error message, which was not perfectly correct in my opinion.
>>
>> The patch was regtested successfully on x86_64-unknown-linux-gnu. Ok for trunk?
>>
>> Part #1, as a regression fix, should also be backported to 4.7 and 4.8. Ok?
>>
>> Cheers,
>> Janus
>>
>>
>>
>> 2013-09-21 Janus Weil <janus@gcc.gnu.org>
>>
>> PR fortran/58355
>> * decl.c (check_extended_derived_type): Prevent segfault, modify error
>> message.
>>
>> 2013-09-21 Janus Weil <janus@gcc.gnu.org>
>>
>> PR fortran/58355
>> * gfortran.dg/extends_15.f90: New.
>
>
>
> --
> The knack of flying is learning how to throw yourself at the ground and miss.
> --Hitchhikers Guide to the Galaxy