This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PR58463] New testcase for pr58463


On Fri, Sep 20, 2013 at 03:45:17PM +0000, Paulo Matos wrote:
> Please find the patch attached.
> 
> I have added the test to gcc.c-torture, please let me know if this is not the right place.
> 
> 	2013-09-20  Paulo Matos <pmatos@broadcom.com>
> 		
> 		* gcc.c-torture/pr58463.c: New testcase.

That is not the right place (and, note the ChangeLog entry refers to a
different path than the testcase, and doesn't have space before <.), such
test should go into gcc.dg/.  But, more importantly, the test doesn't
cleanup after itself.  I bet it is enough to test just one dump that
was actually crashing rather than all of them, so please change that
to -fdump-tree-<whateverpass>-all and add corresponding:
/* { dg-final { cleanup-tree-dump "<whateverpass>" } } */
line.  Or, if you really want to test more than one pass dump, add
the individual -fdump-tree-pass1-all -fdump-tree-otherpass2-all
and corresponding cleanup-tree-dump lines for each of them.  I don't think
there is a way to get all dumps cleaned up.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]