This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [ping][PATCH][1 of 2] Add value range info to SSA_NAME for zero sign extension elimination in RTL


On Wed, 18 Sep 2013, Jan Hubicka wrote:

> > On Wed, Sep 18, 2013 at 10:57:57AM +0200, Richard Biener wrote:
> > > On Wed, 18 Sep 2013, Richard Earnshaw wrote:
> > > 
> > > > On 16/09/13 15:13, Richard Biener wrote:
> > > > > +void
> > > > > +get_range_info (tree name, double_int &min, double_int &max,
> > > > > +                enum value_range_type &range_type)
> > > > > 
> > > > > I'm not sure we want to use references.  Well - first time.
> > > > 
> > > > Personally, I don't think we should ever allow non-const references.
> > > > Use of references means you can't tell from the source code that an
> > > > argument to a function can be modified.  It leads to confusion and makes
> > > > things harder to debug.
> 
> I use non-const references in ipa-devirt code and speculative indirect call removal.
> I am not thrilled by them, just it seems common in C++ source bases.  If we don't want
> them, i will remove these (they are used on two or three places, so it is  easy)

Yeah, I think we should amend the coding conventions appropriately.

Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]