This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [buildrobot] [PATCH] r202527: ssa / ssanames restructure broke alpha-linux


On Mon, Sep 16, 2013 at 4:50 PM, Michael Matz <matz@suse.de> wrote:

>> > Why do you think so?  The t-* frags are includes via
>> > ...
>> > tmake_file=...$(srcdir)/config/i386/t-i386
>> > ...
>> > ifneq ($(tmake_file),)
>> > include $(tmake_file)
>> > endif
>> > ...
>> >
>> > It's just that there's no t-alpha frag yet.
>>
>> No, there is no problem with includes. The *dependencies* from t-*
>> files are missing.
>
> No, because the t- frags contain the dependencies and the t- frags are
> included by make verbatim, hence they're there when building target.o.
>
>> Please compare i386.o dependencies from config/i386/t-i386 with
>> $(out_object_file) from the resulting Makefile in the build directory.
>> They are NOT the same,
>
> Of course not.  But as $(out_object_file) is 'i386.o' they will be
> dependencies for the same target.
>
>> the dependencies in the Makefile from the build
>> directory for $(out_object_file) AKA i386.o are copied verbatim from
>> Makefile.in.
>
> Sure.  And the Makefile _includes_ the t- frags, which means for i386,
> that there are two dependency sets, once from Makefile.in copied into
> Makefile, for $(out_object_file), and once explicitely for i386.o from the
> t-i386 frag included by Makefile.

Thanks for your explanation, I was not aware that we actually have two
dependency sets for the same file. It was not obvious when looking
into generated Makefile, and I was not even sure that this is allowed.

I will prepare the corresponding t-alpha file that will set correct dependecies.

Thanks,
Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]