This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: RFC - Refactor tree.h
- From: Diego Novillo <dnovillo at google dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Andrew MacLeod <amacleod at redhat dot com>, gcc-patches <gcc-patches at gcc dot gnu dot org>
- Date: Mon, 16 Sep 2013 09:39:27 -0400
- Subject: Re: RFC - Refactor tree.h
- Authentication-results: sourceware.org; auth=none
- References: <20130809223645 dot GA22559 at google dot com> <48A1A20B-1DF2-45A5-9CB6-13CDC6A89A4F at comcast dot net> <cf6d07ba-b8bc-43c2-9f84-e7709ed7730e at email dot android dot com> <5214F775 dot 60702 at redhat dot com> <B962A2B6-233D-4B65-B4BF-CE1B20B0154B at comcast dot net> <52161471 dot 6040408 at redhat dot com> <CAD_=9DTQhKGQHn6KgGJg9bQN9_Ft5DaE3fKJr8OuaALhjQSy+g at mail dot gmail dot com> <6A000F64-A10C-4E37-81C5-FF4DEFBF7939 at comcast dot net> <CAFiYyc1CNicD_WhR2ax1FCMNW552_LeSNsd1QDNcq_0C3+o6Sw at mail dot gmail dot com> <20130913150701 dot GE1817 at tucnak dot redhat dot com> <CAD_=9DSiV-nPDZGKJvrKZNVa3ack4U5OXPpvm3nDd-HUeSrsOQ at mail dot gmail dot com>
On Fri, Sep 13, 2013 at 11:25 AM, Diego Novillo <dnovillo@google.com> wrote:
> On Fri, Sep 13, 2013 at 11:07 AM, Jakub Jelinek <jakub@redhat.com> wrote:
>
>> E.g. today I've noticed you've lost OMP_CLAUSE_LINEAR_NO_COPYIN
>> comment that has been added to tree.h recently, but you haven't
>> actually moved it into tree-core.h.
>
> Sorry about that. I remember an update conflict, but I thought I had
> incorporated it all. I will double check and fix.
Done.
gcc/ChangeLog | 5 +++++
gcc/tree-core.h | 19 +++++++++++++++++--
2 files changed, 22 insertions(+), 2 deletions(-)
diff --git a/gcc/ChangeLog b/gcc/ChangeLog
index b9a335a..906d01b 100644
--- a/gcc/ChangeLog
+++ b/gcc/ChangeLog
@@ -1,3 +1,8 @@
+2013-09-16 Diego Novillo <dnovillo@google.com>
+
+ * tree-core.h: Add missing comment lines from refactoring
+ of tree.h.
+
2013-09-16 Jan Hubicka <jh@suse.cz>
* gimple-fold.c (can_refer_decl_in_current_unit_p): Do not accept
diff --git a/gcc/tree-core.h b/gcc/tree-core.h
index b1bc56a..69777dc 100644
--- a/gcc/tree-core.h
+++ b/gcc/tree-core.h
@@ -780,6 +780,9 @@ struct GTY(()) tree_base {
OMP_CLAUSE_PRIVATE_DEBUG in
OMP_CLAUSE_PRIVATE
+ OMP_CLAUSE_LINEAR_NO_COPYIN in
+ OMP_CLAUSE_LINEAR
+
TRANSACTION_EXPR_RELAXED in
TRANSACTION_EXPR
@@ -800,6 +803,9 @@ struct GTY(()) tree_base {
OMP_CLAUSE_PRIVATE_OUTER_REF in
OMP_CLAUSE_PRIVATE
+ OMP_CLAUSE_LINEAR_NO_COPYOUT in
+ OMP_CLAUSE_LINEAR
+
TYPE_REF_IS_RVALUE in
REFERENCE_TYPE
@@ -935,6 +941,9 @@ struct GTY(()) tree_base {
DECL_NONLOCAL_FRAME in
VAR_DECL
+
+ TYPE_FINAL_P in
+ RECORD_TYPE, UNION_TYPE and QUAL_UNION_TYPE
*/
struct GTY(()) tree_typed {
@@ -1197,8 +1206,7 @@ struct GTY(()) tree_decl_common {
unsigned lang_flag_7 : 1;
unsigned lang_flag_8 : 1;
- /* In LABEL_DECL, this is DECL_ERROR_ISSUED.
- In VAR_DECL and PARM_DECL, this is DECL_REGISTER. */
+ /* In VAR_DECL and PARM_DECL, this is DECL_REGISTER. */
unsigned decl_flag_0 : 1;
/* In FIELD_DECL, this is DECL_BIT_FIELD
In VAR_DECL and FUNCTION_DECL, this is DECL_EXTERNAL.
@@ -1403,6 +1411,9 @@ struct GTY(()) tree_statement_list
struct tree_statement_list_node *tail;
};
+
+/* Optimization options used by a function. */
+
struct GTY(()) tree_optimization_option {
struct tree_common common;
@@ -1418,6 +1429,8 @@ struct GTY(()) tree_optimization_option {
struct target_optabs *GTY ((skip)) base_optabs;
};
+/* Target options used by a function. */
+
struct GTY(()) tree_target_option {
struct tree_common common;
@@ -1563,6 +1576,8 @@ struct GTY(()) tree_map_base {
tree from;
};
+/* Map from a tree to another tree. */
+
struct GTY(()) tree_map {
struct tree_map_base base;
unsigned int hash;
--
1.8.4